chore: remove deprecated GitHub image bed feature#124
Merged
Conversation
GitHub image bed (remote image hosting via GitHub Contents API) was removed from the Settings UI in a prior change, but backend code and frontend state lingered. This completes the removal: - Delete githubUpload.ts; saveFile.ts drops the saveFileWithImageBed dispatcher and uploads.ts now calls saveUploadedFile directly. - Drop GITHUB_IMAGE_* from settings SECRET_KEYS/WRITABLE_KEYS, envFile.ts serialization, and value validation. - Remove imageBedLabel plumbing through navigationDataCache -> Home -> MediaLibrary; loadHomePageChromeData no longer fetches /api/settings just to read the now-removed flag. - Sync docs: AGENTS.md, CLAUDE.md, docs/configuration.md, README_zh.md. Local image upload (used by MediaLibrary and platform re-upload during publishing) is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GitHub image bed (remote image hosting via the GitHub Contents API) was removed from the Settings UI in a prior change, but backend code and frontend state lingered. This PR completes the removal.
Changes
Backend
apps/api/src/lib/upload/githubUpload.tssaveFile.tsdrops thesaveFileWithImageBeddispatcher;uploads.tsnow callssaveUploadedFiledirectlysettings.tsremoves allGITHUB_IMAGE_*keys fromSECRET_KEYS/WRITABLE_KEYSand value validationenvFile.tsdrops the# GitHub Image Bedsection from the serialization templateFrontend
navigationDataCache.tsremoves theimageBedLabelfield;loadHomePageChromeDatano longer fetches/api/settingsjust to read the now-removed flagHome.tsxdrops theimageBedLabelstate and prop passthroughMediaLibrary.tsxremoves theimageBedLabelpropDocs
AGENTS.md/CLAUDE.md: drop the image-bed env vars section and add "GitHub image bed" to Removed Product Areasdocs/configuration.md: remove the GitHub Image Bed section entirelyREADME_zh.md: drop image-bed wording from the routes table, feature description, and configuration noteOut of Scope (Unaffected)
/api/upload→.publio-data/uploads/)imageUpload.ts)Verification
pnpm lintpassespnpm buildpassesapps/apitsc --noEmitpassespnpm testpasses (no test files)