[TorBox] fix: remove usage of GetHashInfoAsync#986
Merged
Conversation
Removes GetHashInfoAsync, and only uses the actual torrentId. This was originally required as cachedtorrents endpoints used to use a different torrentId to the regular torrent endpoints for whatever reason, but luckily they figured out a while ago that that was not a good idea and just combined them which means calling API to search for hashes isnt needed anymore, hopefully this will reduce rate limiting a bit.
Contributor
Author
|
acb4877 This migrates existing torrents so that users dont have to delete and re add everything currently in rdtclient. I'll make another PR in 3-6 months to remove this once enough users have probably updated, since it doesn't look particularly nice in my opinion but I couldn't think of a better way to do it. |
acb4877 to
c6f6008
Compare
rogerfar
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes GetHashInfoAsync, and only uses the actual torrentId.
This was originally required as cachedtorrents endpoints used to use a different torrentId to the regular torrent endpoints for whatever reason, but luckily TorBox figured out a while ago that that was not a good idea and just combined them which means calling the API and filtering it by torrent hash to find the torrent id isn't needed anymore. This fixes #971, as it wont use the old torrentId anymore since it'll get the new one when the torrent is made. This should hopefully also reduce rate limiting a little bit.