Support table aliases on associated relations #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cllns
commented
Jul 3, 2024
| assoc = associations[other] | ||
| assoc = associations.key?(other) && associations[other] | ||
|
|
||
| if join_cond.eql?(EMPTY_HASH) && !block |
Author
There was a problem hiding this comment.
Suggested change
| if join_cond.eql?(EMPTY_HASH) && !block | |
| if (join_cond.nil? || join_cond.empty?) && !block |
I'd rather do this. It'd allow nil or {} or [] as join_cond, which are all valid IMO.
I'm not sure why this was .equal?, since that does object equality (so even passing in {} would be false since it's a different though identical object).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this bug the other week. If you call
joinwith a relation object,table_aliasdoesn't work at all. It only works with the name a symbol.Note this is a PR against release-3.6, not main.
Each commit fixes a different situations, so I recommend viewing each commit separately.