Repository navigation
ci(harness): a retry that passes no longer fails the job - #67
Merged
Merged
Conversation
The harness action snapshots .harness/cache/metro before each run and
passes the listing to its "Plan Metro cache save" step as one environment
variable. The first run starts from an empty cache (71 bytes); the retry
starts from the first run's full cache, ~157 KB, over Linux's 128 KB limit
on a single environment string. bash could not start ("Argument list too
long") and the job failed even though all 119 tests passed on the retry:
main after #60, #65 and #66.
Clear the Metro cache before each retry so its listing is as small as the
first run's. iOS gets the same step.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the first attempt of the on-device suites fails, the retry runs. If the retry passes, the job still goes red:
This happened on
mainafter #60, and on #65 and #66. In each case the retry passed all 119 tests.Cause.
callstackincubator/react-native-harness@v1.5.0snapshots.harness/cache/metrobefore it runs. It then hands that listing to its "Plan Metro cache save" step asINPUT_METRO_SNAPSHOT:Fix. Delete the Metro cache before each retry, so its listing is as small as the first run's. The retry already had to transform everything; on a fresh runner that is what the first run does. iOS gets the same step: macOS has no per-string limit, but the listing grows the same way.
Testing. This PR's own checks only reach the retry if a first attempt flakes. The change is a
rm -rfof the two folders the action restores and snapshots (action.ymllines 171–197).🤖 Generated with Claude Code