feat(x): folders as workspaces — linked folders, list view, live workspace chats - #799
Open
arkml wants to merge 3 commits into
Open
feat(x): folders as workspaces — linked folders, list view, live workspace chats#799arkml wants to merge 3 commits into
arkml wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three changes to the Workspaces section, verified end-to-end by driving the app with Playwright:
1. Any folder can be added as a workspace (
4c461259)config/workspace-folders.jsonrecords{id, name, path}.@folder/<id>/…path space inresolveWorkspacePath/absToRelPosix, containment-checked against the linked root — every existingworkspace:*IPC (readdir/read/write/rename/remove/reveal) works on linked folders unchanged.shell.trashIteminto core) —WorkDir/.trashwould fail cross-volume and leak files into Rowboat's workdir.node_moduleswould EMFILE — seewatcher.ts); the view refreshes on navigation/focus + manual Refresh. Linked folders also stay out of the knowledge index/graph, wiki links, and version history by construction.2. Workspace browsing is a list view (
408c084b)6h ago,Yesterday,Jul 20; exact timestamp on hover).localStorage. Folders group first only when sorting by name.3. Workspace chats work again, and live (
ab78c975)runs:listByWorkDirstill scanned legacyruns/*.jsonl, which the boot migration moves toruns-archive/— so the Chats panel was always empty. It now filters the in-memory session index against theconfig/workdir-<id>.jsonsidecars (newruntime/sessions/by-workdir.ts); dead legacy implementation removed.sessions:events(create/retitle/delete) and on a newWORKSPACE_CHATS_CHANGEDrenderer event fired when a chat's work directory is set — covering the no-navigation case where the workspace is open in the middle pane while the chat sits in the right pane.Verification
Driven in the real app (isolated
ROWBOAT_WORKDIR, real session fixtures): add/browse/edit/rename/delete in linked folders incl. path-traversal + boundary rejections; sort flips and persistence; chats panel populated from a real migrated session, nested-dir matching, live appearance of new/retitled/moved-in chats.npm run typecheckclean; lint unchanged frommain(same 11 pre-existing errors).Known follow-ups
🤖 Generated with Claude Code