fix(todo): make sticky-dismissed suggestions immune to feedback-log truncation - #831
Open
Gagancreates wants to merge 1 commit into
Open
fix(todo): make sticky-dismissed suggestions immune to feedback-log truncation#831Gagancreates wants to merge 1 commit into
Gagancreates wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where the Home suggestion tray could re-show a suggestion the user had already declined. The sticky-dismissed verdict was previously derived from the bounded 200-entry planner feedback ledger, so enough unrelated signals could truncate the original dismissal and allow the suggestion to be proposed again.
This change adds a new uncapped
todo/sticky_dismissed.jsonstore separate from the bounded feedback ledger. Dismissed and taught signals upsert into that sticky store, while later ran or kept signals remove the key to preserve the existing override semantics. The bounded ledger remains in place for recent outcome examples.It also awaits planner signal persistence at the accept, decline, dismiss, teach, and run call sites while still swallowing signal-recording failures, closing the race where a planner run could read sticky dismissals before a just-recorded user action had reached disk.
Fixes #830
Testing
apps/x/packages/core/src/todo/planner-memory.test.tscovering sticky dismissal persistence past feedback-log truncation, taught signals, and ran/kept overrides.npm test -- src/todo/fileops.test.ts src/todo/planner-memory.test.ts: 2 files passed, 11 tests passed.npm testinapps/x/packages/core: 54 files passed, 583 tests passed.npm run typecheckinapps/x/packages/core: passed.npm run buildinapps/x/packages/core: passed.npm run buildinapps/x/apps/main: passed.