fix(x): product tour stuck on first step in dev (StrictMode double-mount)

[YarnMeister]

Problem

Running npm run dev and clicking Take a tour dims the screen and shows the water/spotlight, but the boat never rows anywhere and the speech bubble (with the Next button) never appears — the tour dead-ends on step 1 of 12. Packaged builds are unaffected.

Root cause

The renderer mounts the app in <StrictMode> (main.tsx), and React 19 double-invokes effects in dev (mount → cleanup → mount). The tour's step effect doesn't survive that round trip:

1. First run: entering = true → settle() sets enteredStepRef.current = stepIndex before startTravel() begins the rAF travel loop.
2. StrictMode cleanup: cancelled = true; cancelTravel() kills the loop.
3. Second run: enteredStepRef.current already matches, so entering = false → the effect takes the resize branch ("jump, keep the bubble up"), which moves the mascot to its destination and returns — setArrived(true) never fires.

Since the bubble only renders when arrived is true, the tour is permanently stuck. Traced via CDP: mascot frozen at its computed destination transform, wake strokeDashoffset never written, zero exceptions.

Fix

Roll the entered marker back in the effect cleanups when the run that set it was torn down before arrival:

const unmarkEntered = () => {
  if (entering && enteredStepRef.current === stepIndex) enteredStepRef.current = -1
}

Resize-triggered re-runs execute with entering === false, so the existing jump-without-re-rowing behavior is preserved.

Verification

• Before: reproduced 100% in dev — tour mounts, no bubble, stuck on step 1 indefinitely.
• After (hard reload, dev): boat rows in from off-screen drawing its wake, bubble appears, and all 12 stops advance cleanly through Done, which tears the tour down fully.
• npm run typecheck:renderer and npm run lint pass.

🤖 Generated with Claude Code