fix(x): hover follow-ups — "Try it" toast summons the real companion; Windows push-to-talk (right Ctrl) - #859
Open
arkml wants to merge 2 commits into
Open
fix(x): hover follow-ups — "Try it" toast summons the real companion; Windows push-to-talk (right Ctrl)#859arkml wants to merge 2 commits into
arkml wants to merge 2 commits into
Conversation
… legacy bar The once-per-install discoverability toast's action still called quickAsk:show — the pre-hover fallback path — so the very first thing a new user saw of "hover mode" was the legacy 800px summoned bar with the hatless mascot. It now runs the exact ⌥⇧Space flow (startHoverCall, via a ref so the timer never captures a stale voice-availability closure), landing on the Skipper card, with the no-voice text-card fallback intact. Toast copy updated to describe what actually happens. quickAsk:show survives only as the deliberate fallback inside startHoverCall for voice-unconfigured installs. Verified: live drive — fresh profile, toast fires, Try it opens the 560px Skipper card (hat + pins), not the 800px legacy bar. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…, not right ⌘)
The global PTT hook hardcoded libuiohook's VC_META_R — on Windows that's
the right Win key, which the OS owns (a tap opens the Start menu), so
hold-to-talk was effectively unusable there. The quick-ask bar's local
listener had already mapped Windows to right Ctrl; now every layer agrees:
- main/ptt.ts hooks VC_CONTROL_R (right Ctrl) off macOS
- the app window's DOM fallback listens for ControlRight off macOS
- every user-facing string ("Hold the mic — or right ⌘", the call view's
status line and talk-button tooltip, the hands-free teach toast) renders
the platform's actual key via a shared pttKeyLabel helper
The ⌥⇧Space summon hint was already platform-formatted (Alt+Shift+Space on
Windows) via formatShortcut — unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
arkml
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #855. The once-per-install discoverability toast's Try it action still called
quickAsk:show— the pre-hover fallback path — so the first thing a new user saw of "hover mode" was the legacy 800px summoned bar with the hatless mascot.startHoverCall, via a ref so the 3s timer never captures a stale voice-availability closure) → lands on the Skipper card. The no-voice text-card fallback is preserved (quickAsk:showsurvives only as that deliberate fallback insidestartHoverCall).Verified live: fresh profile → toast fires → Try it opens the 560px Skipper card (hat + pins + ↗), not the 800px legacy bar. Typecheck + lint clean.
🤖 Generated with Claude Code
Also: push-to-talk on Windows (right Ctrl, not right ⌘)
Bigger than a wording bug: the global PTT hook hardcoded
VC_META_R, which on Windows is the right Win key — the OS owns it (tap = Start menu), so hold-to-talk was effectively unusable off macOS. Now every layer agrees on right Ctrl for Windows/Linux: the uiohook keycode inmain/ptt.ts, the app window's DOM fallback (ControlRight), and every user-facing string (Skipper chip, call-view status line + talk-button tooltip, the hands-free teach toast) via a sharedpttKeyLabelhelper. The ⌥⇧Space hint was already platform-formatted (Alt+Shift+Spaceon Windows) and is unchanged.