fix(macos): degrade fullscreen detection capability to false (F03/F28)#29
Merged
Conversation
`detect_fullscreen_macos` has always returned `DegradedFalse` (no real NSWorkspace / CGWindowList implementation), yet `PlatformApi` claimed to support fullscreen detection. The "Fullscreen Skip" toggle in Settings therefore appeared functional on macOS but did nothing. This is the v0.7.0 degrade-only fix for sub-branch #5 of the v0.7.0-hardening epic. Real macOS fullscreen detection is deferred to v0.7.x follow-up per prd.md §五 risk table. Changes: - Add `supports_fullscreen_detection(&self) -> bool` to PlatformApi. - macOS: returns false (capability gates UI off). - Windows: returns true. - Linux: returns true on X11 with a session, false on Wayland. - Extend DetectorCapabilities with fullscreen_detection_supported field; ts-rs binding regenerated. - Disable the "Fullscreen Skip" toggle in SettingsPage when capability is false; description swaps to a new i18n note pointing at v0.7.x. - New zh-CN/en string: settings.behavior.fullscreenUnsupported. - Add unit tests on macos.rs (capability=false, behavior stays false) and detector.rs (capability reflects unsupported fullscreen). - Add 2 Svelte tests covering disabled/enabled toggle states. - Sync .trellis/spec/backend/platform-storage.md trait + matrix + degradation principle. Not done in this PR (left to v0.7.x): - Real macOS fullscreen detection (NSWorkspace / Spaces / multi-display). Refs: docs/.local/v1.0.0-audit-report.md F03, F28 Epic: v0.7.0 hardening (sub-branch #5 of 9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes F03 (P0) + F28 (P3) from
docs/.local/v1.0.0-audit-report.md— degrade-only fix for v0.7.0. Real macOS fullscreen detection is deferred to v0.7.x follow-up per prd.md §五 risk table. Epic sub-branch #5 of 9.detect_fullscreen_macosalways returnedDegradedFalse(no real NSWorkspace / CGWindowList impl), yetPlatformApireported fullscreen-detection capability astrue. UI toggle appeared functional but did nothing.What changed
PlatformApi::supports_fullscreen_detection(&self) -> booladdedfalsetruetrueon X11 + session present;falseon WaylandDetectorCapabilitiesgainsfullscreen_detection_supported: bool(ts-rs regenerated)SettingsPage.sveltedisables the "Fullscreen Skip" toggle + swaps description to a new i18n note (settings.behavior.fullscreenUnsupported) when capability isfalse.trellis/spec/backend/platform-storage.mdsynced (trait + capability matrix + degradation principle)Tests (all green)
supports_fullscreen_detection_returns_false_on_macos,fullscreen_active_stays_false_when_capability_off,capability_reflects_unsupported_fullscreen_detectionnpm run ciall 8 steps passNOT done in this PR (deferred to v0.7.x)
detect_fullscreen_macosto returnDetected(bool), flip capability totrue, remove the v0.7.x i18n noteConstraints honored
Audit context
Part of v0.7.0 hardening epic — see
.trellis/tasks/05-23-v0-7-0-hardening-release-epic/prd.md. Concurrent: #3refactor/remove-defensive-code(background).🤖 Generated with Claude Code