security(api): Remove transaction registration and server-side logging endopoints#1419
Open
ronaldsg20 wants to merge 3 commits into
Open
security(api): Remove transaction registration and server-side logging endopoints#1419ronaldsg20 wants to merge 3 commits into
ronaldsg20 wants to merge 3 commits into
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



📌 Summary
Removes the
registerTxandlogToServerAPI calls — along with all supporting types — that were sending transaction details and operational log entries to the backend from both the pegin and pegout flows.🔍 Description
What was changed:
ApiService.registerTx()andApiService.logToServer()methods fromApiService.ts.ConfirmTx.vue(pegin flyover & native),PegoutForm.vue(pegout flyover & native), and both Flyover store action files (FlyoverPegin/actions.ts,FlyoverPegout/actions.ts).TxInfo.tstype file entirely (heldTxInfo,BaseQuoteDbModel,PeginQuoteDbModel,PegoutQuoteDbModel).LogEntry,LogEntryType, andLogEntryOperationfromCommon.ts.TxInfobarrel export fromcommon/types/index.ts.registerFlyover,registerPegout,flyoverProps,nativeProps,getLPName,getProviderFee,currentWalletthat existed solely to build the payloads for those calls.useWalletInfoimport fromPegoutForm.vue(was only needed forcurrentWallet).registerTxunit tests fromApiService.spec.ts.CLAUDE.mdwith AI assistant guidance and updated.gitignoreto exclude.claude/.Scope of impact:
/registerand/logsendpoints will no longer receive calls from this client.🧪 How to Test
.env.localpointing to a2wp-apiinstance (see.env.local.test).npm run serveand openhttps://localhost:8080./registershould occur./registeror/logsin network traffic./register./registeror/logs.npm run test— all tests should pass (theregisterTxtests are removed; no other tests should be broken).npm run lint— no ESLint errors.🧠 Known Issues / Limitations
/registerand/logsendpoints are now dead from this client. Backend cleanup (removing or deprecating those endpoints) should be tracked separately.📎 Related task