Peg-out acceptance#350
Open
SergioDemianLerner wants to merge 9 commits into
Open
Conversation
Collaborator
Author
|
Working on performance improvements. Not yet ready for merging, |
ilanolkies
suggested changes
Sep 12, 2022
Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com>
ilanolkies
reviewed
Sep 13, 2022
ilanolkies
left a comment
ilanolkies
left a comment
Contributor
There was a problem hiding this comment.
I can do a further review if needed 🙂 i just checked grammars in the last review
smishraIOV
reviewed
Sep 22, 2022
smishraIOV
left a comment
smishraIOV
left a comment
Contributor
There was a problem hiding this comment.
I understand the motivation. But I am struggling to follow the core solution.
|
|
||
| In this proposal, we give pegnatories the capability to accept peg-outs before they are included in the batch and signed. | ||
|
|
||
| # **Specification** |
Contributor
There was a problem hiding this comment.
This section reads more like mechanics and implementation. I am not sure I follow the high level concept. Why do we need 3 actions (accept/reject/cancel)? The main idea is not very clear to me.
Collaborator
Author
There was a problem hiding this comment.
The specification does not need to describe the high level concept. Maybe that should be explained in the Motivation section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.