Skip to content

chore: migrate linting to rslint#84

Merged
chenjiahan merged 1 commit intomainfrom
chenjiahan/migrate-rslint-prettier
Apr 28, 2026
Merged

chore: migrate linting to rslint#84
chenjiahan merged 1 commit intomainfrom
chenjiahan/migrate-rslint-prettier

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

This PR migrates the lint workflow from Biome to Rslint plus Prettier, following the rsbuild plugin template. It adds rslint.config.ts, updates lint scripts and the pre-commit hook command, removes Biome/nano-staged, and refreshes the lockfile for the new lint dependency.

Copilot AI review requested due to automatic review settings April 28, 2026 09:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Migrates the project’s linting workflow from Biome to Rslint + Prettier, updating scripts, hooks, and configuration accordingly.

Changes:

  • Added rslint.config.ts using TypeScript + React recommended configs with a couple rule overrides.
  • Updated package.json lint scripts and pre-commit hook; removed Biome and nano-staged.
  • Removed biome.json and added a .prettierignore entry for the lockfile.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
rslint.config.ts Introduces Rslint configuration (TS + React recommended + overrides).
package.json Swaps lint tooling to rslint + prettier, removes Biome/nano-staged, updates pre-commit hook.
biome.json Deletes Biome configuration after migration.
AGENTS.md Updates developer docs to reflect the new linting commands and hook behavior.
.prettierignore Prevents Prettier from touching the lockfile.
.github/workflows/test.yml Minor YAML formatting/quoting adjustment.
.github/workflows/release.yml Minor YAML quoting adjustment for tag pattern and action input.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment thread package.json
Comment thread .prettierignore
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 99bd14c411

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
@chenjiahan chenjiahan merged commit e4aeeb5 into main Apr 28, 2026
8 of 10 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/migrate-rslint-prettier branch April 28, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants