Sync main with develop after release 1.4.1#1135
Merged
Merged
Conversation
Merge develop to release 1.4.1 branch
Release/1.4.1
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the main branch with the develop branch after the 1.4.1 release, updating version numbers and changelog information across multiple files to reflect the new release.
- Updates version number from 1.4.0 to 1.4.1 across all relevant files
- Adds changelog entries for v1.4.1 with audio recording enhancements and video player fixes
- Updates localization files with new translation strings and reference updates
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.txt | Updates stable tag to 1.4.1 and adds changelog entry |
| package.json | Updates version field to 1.4.1 |
| languages/godam.pot | Updates project version and POT creation date |
| inc/helpers/custom-functions.php | Updates @SInCE tag from "n.e.x.t" to "1.4.1" |
| godam.php | Updates plugin version and constant to 1.4.1 |
| assets/src/js/godam-player/analytics.js | Simplifies video analytics tracking implementation |
| README.md | Updates stable tag to 1.4.1 |
| CHANGELOG.md | Adds v1.4.1 changelog entry |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| * Note: The files created by uppy webcam, screen capture, and audio plugin are in the same format. So we are checking the filename to determine if it's an audio file. | ||
| * | ||
| * @since n.e.x.t | ||
| * @since 1.4.1 |
There was a problem hiding this comment.
The @SInCE tag should use 'n.e.x.t' format during development and only be updated to the actual version number in the final release commit. Since this is a sync from develop to main after release, this change is appropriate.
Comment on lines
+47
to
80
| videos.forEach( ( video ) => { | ||
| // read the data-setup attribute. | ||
| const player = videojs( video ); | ||
|
|
||
| window.addEventListener( 'beforeunload', () => { | ||
| const played = player.played(); | ||
| const ranges = []; | ||
| const videoLength = player.duration(); | ||
|
|
||
| // Extract time ranges from the player.played() object | ||
| for ( let i = 0; i < played.length; i++ ) { | ||
| ranges.push( [ played.start( i ), played.end( i ) ] ); | ||
| } | ||
|
|
||
| // Send the ranges using updateHeatmap | ||
| updateHeatmap( ranges, videoLength ); | ||
| } ); | ||
| } ); | ||
|
|
||
| // Per-video initialization (no global listeners here) | ||
| videos.forEach( ( video ) => { | ||
| videojs( video ); | ||
| async function updateHeatmap( ranges, videoLength ) { | ||
| const videoId = video.getAttribute( 'data-id' ); | ||
| if ( ! videoId || ranges.length === 0 ) { | ||
| return; // Skip sending if no valid data | ||
| } | ||
|
|
||
| if ( window.analytics ) { | ||
| window.analytics.track( 'video_heatmap', { | ||
| type: 2, // Enum: 2 = Heatmap | ||
| videoId: parseInt( videoId, 10 ), | ||
| ranges, | ||
| videoLength, | ||
| } ); | ||
| } | ||
| } | ||
| } ); |
There was a problem hiding this comment.
Adding a 'beforeunload' event listener inside the forEach loop will create multiple identical event listeners, one for each video. This should be moved outside the loop or use a single listener that handles all videos.
| // Per-video initialization (no global listeners here) | ||
| videos.forEach( ( video ) => { | ||
| videojs( video ); | ||
| async function updateHeatmap( ranges, videoLength ) { |
There was a problem hiding this comment.
The updateHeatmap function is declared as async but doesn't use await or return a Promise. Either remove the async keyword or add proper async functionality.
Suggested change
| async function updateHeatmap( ranges, videoLength ) { | |
| function updateHeatmap( ranges, videoLength ) { |
Juzar10
approved these changes
Sep 18, 2025
subodhr258
approved these changes
Sep 18, 2025
KMchaudhary
added a commit
that referenced
this pull request
Sep 18, 2025
This reverts commit 202a06e.
KMchaudhary
added a commit
that referenced
this pull request
Sep 18, 2025
KMchaudhary
added a commit
that referenced
this pull request
Sep 19, 2025
…1148) * Sync main with develop after release 1.4.1 (#1135) * docs: Update changelog and version to 1.4.1 (#1130) * Hotfix/analytics gallery (#1133) * Revert "Fix - Analytics tracking for dynamically rendered videos (#1105)" This reverts commit 835226f. * docs: Remove reverted analytics commit from changelog --------- Co-authored-by: Subodh Rajpopat <subodh.rajpopat@rtcamp.com> * Revert "Sync main with develop after release 1.4.1 (#1135)" (#1136) This reverts commit 202a06e. * New sequence for media src HLS, MPD, Original URL to fix safari Audio mute issue * Provide HLS URL support on [godam_video] shortcode --------- Co-authored-by: Subodh Rajpopat <subodh.rajpopat@rtcamp.com> Co-authored-by: KMchaudhary <kuldipkumar.chaudhary@rtcamp.com>
subodhr258
added a commit
that referenced
this pull request
Sep 22, 2025
* Sync main with develop after release 1.4.1 (#1135) * docs: Update changelog and version to 1.4.1 (#1130) * Hotfix/analytics gallery (#1133) * Revert "Fix - Analytics tracking for dynamically rendered videos (#1105)" This reverts commit 835226f. * docs: Remove reverted analytics commit from changelog --------- Co-authored-by: Subodh Rajpopat <subodh.rajpopat@rtcamp.com> * Revert "Sync main with develop after release 1.4.1 (#1135)" (#1136) This reverts commit 202a06e. * fix: exclude jetpack_contact_form_jwt field while submitting the jetpack forms (#1134) * Fix the audio mute issue on mac safari browser for GoDAM video block (#1142) * New sequence for media src HLS, MPD, Original URL to fix safari Audio mute issue * Provide HLS URL support on [godam_video] shortcode --------- Co-authored-by: KMchaudhary <kuldipkumar.chaudhary@rtcamp.com> * Custom Thumbnail Upload Allows MP4 Video via “Upload Files” Option (#1126) * fix: allow only image upload * remove unused code * update snackbar message * FIX: Remove `filemtime` warnings * FEAT: Close autoadvance upon `x` button click --------- Co-authored-by: Kuldip Chaudhary <64731232+KMchaudhary@users.noreply.github.com> Co-authored-by: nani samireddy <60937910+nani-samireddy@users.noreply.github.com> Co-authored-by: KMchaudhary <kuldipkumar.chaudhary@rtcamp.com> Co-authored-by: Prachi Garg <72646230+prachigarg19@users.noreply.github.com> Co-authored-by: Vipul Patil <vipulrpatil.8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.