Main to Develop sync after 1.4.7 release#1374
Conversation
Sync Develop to Main
feat: Version and Changelog for 1.4.7
There was a problem hiding this comment.
Pull request overview
This PR syncs the main branch to the develop branch after the 1.4.7 release. The changes update version numbers across all relevant files, add the 1.4.7 changelog entry, update translation strings, and include a minor documentation fix.
Key Changes
- Version number bumped from 1.4.6 to 1.4.7 across all configuration files
- Added 1.4.7 changelog with bug fixes and performance improvements
- Updated translation file with new/modified strings and promotional banner content
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.txt | Updated stable tag to 1.4.7 and added v1.4.7 changelog entry |
| package.json | Bumped version to 1.4.7 |
| package-lock.json | Bumped version to 1.4.7 in lockfile |
| languages/godam.pot | Updated version, creation date, and translation strings |
| inc/classes/class-media-library-ajax.php | Fixed @SInCE tag from "n.e.x.t" to "1.4.7" |
| godam.php | Updated plugin version and constant to 1.4.7 |
| README.md | Updated stable tag to 1.4.7 |
| CHANGELOG.md | Added v1.4.7 changelog entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Fix: GoDAM media tab for WP core blocks | ||
| - Fix: Virtual media player and preview template | ||
| - Fix: Error handling for Ads layer | ||
| - Fix: PHP naming conventions as per WP PCP |
There was a problem hiding this comment.
The acronym 'PCP' appears to be a typo. Based on WordPress context, this should likely be 'PHPCS' (PHP_CodeSniffer) or 'PCS' (PHP Coding Standards). Please verify and correct.
| - Fix: PHP naming conventions as per WP PCP | |
| - Fix: PHP naming conventions as per WP PHPCS |
| - Fix: GoDAM media tab for WP core blocks | ||
| - Fix: Virtual media player and preview template | ||
| - Fix: Error handling for Ads layer | ||
| - Fix: PHP naming conventions as per WP PCP |
There was a problem hiding this comment.
The acronym 'PCP' appears to be a typo. Based on WordPress context, this should likely be 'PHPCS' (PHP_CodeSniffer) or 'PCS' (PHP Coding Standards). Please verify and correct.
| - Fix: PHP naming conventions as per WP PCP | |
| - Fix: PHP naming conventions as per WP PHPCS |
| #. translators: %d: Label of the video text track e.g: "French subtitles". | ||
| #: assets/build/blocks/godam-player/index.js:5 | ||
| #: assets/src/blocks/godam-player/edit.js:244 | ||
| #: assets/src/blocks/godam-player/edit.js:269 | ||
| #, js-format | ||
| msgctxt "video caption" | ||
| msgid "Failed to load video data with id: %d" |
There was a problem hiding this comment.
The translator comment is inconsistent with the actual message. The comment mentions 'Label of the video text track' (suggesting a string), but the message 'Failed to load video data with id: %d' expects an integer ID, not a label. The comment should be updated to accurately describe that %d represents a video data ID, not a text track label.
Issue - https://github.com/rtCamp/godam-core/issues/505