style: format the codebase and clear clippy -D warnings#30
Merged
Conversation
The CI `Check formatting` and `Clippy` gates were red on master because the existing code was never run through rustfmt and carried three clippy warnings (pre-existing, inherited — they failed even on PRs with no Rust changes). - `cargo fmt --all` over the whole tree (pure formatting, no behavior change). - cmd_claim: allow clippy::too_many_arguments (the 9 args are the CLI flag set). - cmd_claim deps loop: `if let Ok(..)` instead of `match` with an empty Err arm. - list_queue: extract the 5-tuple into a `QueueRow` type alias. `cargo fmt --check`, `cargo clippy --all-targets -- -D warnings`, and the test suite (77) all pass, so the CI gate goes green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
grit's notification room uses Unix domain sockets (std::os::unix::net in src/room/mod.rs and the `grit watch` path), so it does not compile on Windows. The build was already broken there; the CI only ever failed earlier at the formatting step, which masked it. Treat grit as Unix/macOS-only for now: - ci.yml: remove the windows-latest matrix entry. - release.yml: remove the x86_64-pc-windows-msvc target. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the CI green. The
Check formattingandClippygates were red onmasterbecause the existing code was never run through rustfmt and carried three clippy warnings — pre-existing/inherited, they failed even on PRs with no Rust changes.cargo fmt --allover the whole tree (pure formatting, no behavior change).cmd_claim:#[allow(clippy::too_many_arguments)](the 9 args are the CLI flag set).cmd_claimdeps loop:if let Ok(..)instead ofmatchwith an emptyErrarm.list_queue: extract the 5-tuple into aQueueRowtype alias.Verification
cargo fmt --all -- --check✅cargo clippy --all-targets -- -D warnings✅ (0 warnings)cargo test✅ 77 passingFirst PR through the new flow → targets
develop(also exercisesci.ymlon develop andpr-target-check).🤖 Generated with Claude Code