fix(filter): handle Python single-line docstrings in MinimalFilter#2713
Open
guyoron1 wants to merge 1 commit into
Open
fix(filter): handle Python single-line docstrings in MinimalFilter#2713guyoron1 wants to merge 1 commit into
guyoron1 wants to merge 1 commit into
Conversation
Single-line docstrings like """Return the sum.""" toggled in_docstring to true but never back to false, causing all subsequent lines to be treated as docstring content. Comments after such docstrings were not stripped, reducing token savings. Check for closing """ on the same line after opening to correctly reset the state. Fixes rtk-ai#2712
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MinimalFilterstate corruption when encountering Python single-line docstrings like"""Return the sum."""in_docstringflag was toggled totruebut never reset when the closing"""appeared on the same lineFix
After toggling
in_docstringon, check if the rest of the line (after the opening""") contains a closing""":Test plan
test_python_single_line_docstring_does_not_corrupt_statetestcargo clippy --all-targetspassescargo test --allpassesFixes #2712