fix(git): handle -n<N> combined form in git log#2740
Open
salarkhannn wants to merge 1 commit into
Open
Conversation
git log -n<N> (e.g. -n20) was not detected by has_limit_flag or parse_user_limit, causing RTK to inject its own -10 limit and then truncate filter_log_output to 10 commits even though git correctly output the user-requested count. Add detection and parsing for the -n<digits> combined form, matching git's accepted syntax.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combined form git log -n (e.g., -n20) was not detected by has_limit_flag or parse_user_limit in run_log. This caused two problems: RTK injected its own -10 limit argument, and filter_log_output used limit=10 with user_set_limit=false, truncating the visible output to 10 commits even though git correctly emitted the user-requested count.
Fix has_limit_flag to detect -n as a limit flag, and add -n parsing to parse_user_limit. Both sites already handled the equivalent forms -20 and -n 20.
Includes tests for -n20 multi-digit and -n5 single-digit forms.
Fixes #2665