Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/pp.rb
Original file line number Diff line number Diff line change
Expand Up @@ -200,14 +200,17 @@ def pop_inspect_key(id)
def pp(obj)
# If obj is a Delegator then use the object being delegated to for cycle
# detection
obj = obj.__getobj__ if defined?(::Delegator) and ::Delegator === obj
delegated = defined?(::Delegator) && ::Delegator === obj
key = delegated ? obj.__getobj__ : obj

if check_inspect_key(obj)
if check_inspect_key(key)
obj = key if delegated and !obj.respond_to?(:pretty_print_cycle)
group {obj.pretty_print_cycle self}
return
end

guard_inspect(obj) do
guard_inspect(key) do
obj = key if delegated and !obj.respond_to?(:pretty_print)
group do
obj.pretty_print self
rescue NoMethodError
Expand Down
16 changes: 16 additions & 0 deletions test/test_pp.rb
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,16 @@ def test_direct_pp
class PPDelegateTest < Test::Unit::TestCase
class A < DelegateClass(Array); end

class Delegated < SimpleDelegator
def inspect
"<delegated>"
end

def pretty_print(q)
q.text inspect
end
end

def test_delegate
assert_equal("[]\n", A.new([]).pretty_inspect, "[ruby-core:25804]")
end
Expand All @@ -325,6 +335,12 @@ def test_delegate_cycle

assert_equal(cycle_pretty_inspect, delegator_cycle_pretty_inspect)
end

def test_delegate_pretty_print
parent = HasPrettyPrint.new nil
delegated = Delegated.new(parent)
assert_equal("<delegated>\n", delegated.pretty_inspect)
end
end

class PPFileStatTest < Test::Unit::TestCase
Expand Down