docs(skills): scale-semantics guidance and value-level LWS eval - #195
Draft
rogirun wants to merge 1 commit into
Draft
docs(skills): scale-semantics guidance and value-level LWS eval#195rogirun wants to merge 1 commit into
rogirun wants to merge 1 commit into
Conversation
A component's replicasPath is the count of its own instances, not the pods beneath it. Add guidance (with the LeaderWorkerSet group-vs-size trap and a sibling-consistency self-check) and a value-level eval that asserts extracted scale numbers against a concrete manifest, so this class of valid-but-wrong scale error is catchable. Relates to #186. Signed-off-by: Roee Gil <roee.gil@run.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skill improvements for
add-workload-type, surfaced by testing it against thebuilt-in catalog:
replicasPathis the count of itsown instances, not the pods beneath it. Grouped/replicated workloads expose two
numbers (how many groups/replicas vs members-per-group); a group-level
component scales on the group count. The LeaderWorkerSet trap
(
group->.spec.replicas, not.spec.leaderWorkerTemplate.size) is spelledout, with a sibling-consistency self-check.
concrete manifest, grounded in the real API, so a valid-but-wrong scale path is
catchable rather than invisible to a match-the-definition comparison.
Stacks on #187.
Related issue(s)
Fixes #194
Checklist
git commit -s)make check) - docs/evals only, no Go impact