Revert "Make iter module public"#240
Closed
tcharding wants to merge 1 commit intorust-bitcoin:1.xfrom
Closed
Conversation
This reverts commit 508962b. We are now releasing `v1.1.0` from master branch so this branch will only be for security patches to `v1.0`. As such we don't want any other changes on the branch. Over on master we kept the `iter` module private and re-exported the iterator types from the crate root.
Member
Author
|
I already ticked of the list item in #209, if this gets shot down be sure to see to that item. |
Member
|
Can you be more specific what this branch is for? Why don't we just delete it? |
Member
Author
|
Ah yes I agree lets do that. |
Member
Author
|
Done, github auto-closed this when I deleted the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 508962b.
We are now releasing
v1.1.0from master branch so this branch will only be for security patches tov1.0. As such we don't want any other changes on the branch.Over on master we kept the
itermodule private and re-exported the iterator types from the crate root.