Support region padding for MPU programming#146
Open
thejpster wants to merge 3 commits intorust-embedded:mainfrom
Open
Support region padding for MPU programming#146thejpster wants to merge 3 commits intorust-embedded:mainfrom
thejpster wants to merge 3 commits intorust-embedded:mainfrom
Conversation
* Add an API to get the various linker output sections (aarch32_rt::region) * Adjust link.x to allow for adjustable alignment of regions * Adjust link.x to allow for adjustable padding between stacks * Add an example that programs the MPU
wt
reviewed
Mar 24, 2026
wt
left a comment
There was a problem hiding this comment.
Everything I didn't mention looks okay assuming all the magic numbers in the reference files are correct.
Comment on lines
+49
to
+60
| pub fn iter() -> impl Iterator<Item = Region> { | ||
| [ | ||
| Region::VectorTable, | ||
| Region::Text, | ||
| Region::Rodata, | ||
| Region::Bss, | ||
| Region::Data, | ||
| Region::Uninit, | ||
| ] | ||
| .iter() | ||
| .cloned() | ||
| } |
There was a problem hiding this comment.
I'm not comfortable that future additions to the Region enum will not get caught if they aren't added to this array. I think that it would be better to have a RegionIter type that implements iterator and makes sure that all the values are in the iterator with an exhaustive match on the current section.
Something like:
struct RegionIter {
current: Region;
};
impl Iterator for RegionIter {
type Item = Region;
fn next(&mut self) -> Option<Self::Item> {
let next = match self.current {
Region::VectorTable => Region::Text,
Region::Text => Region::Rodata,
// etc...
Region::Uninit => return None,
}
self.current = next
Some(next)
}
}iter() should return this initialized RegionIter.
wt
suggested changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it easier to set up the MPU
The MPS3-AN536 padding is set at 64K, so that the normal build and the +d32 build end up with the same memory map (otherwise their output for the mpu_region example would be different).