Explain test case, rename anchor const for readability#45
Open
chrysn wants to merge 1 commit intorust-embedded:masterfrom
Open
Explain test case, rename anchor const for readability#45chrysn wants to merge 1 commit intorust-embedded:masterfrom
chrysn wants to merge 1 commit intorust-embedded:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rename is primarily because I didn't get what the constant on the first read (and it really gets to you when you review code and find something that's obviously there for a purpose but it's also obviously not actually doing anything).
The comment is added to help readers who are led astray by the earlier warnings to not let the user pick the produced lifetime of a CS (here it's really controlled by the consumer) and miss that the mutex itself is shortlived.