security: pin GitHub Actions to commit SHAs and add audit workflow#830
Open
rogerkorantenng wants to merge 1 commit intorust-lang:masterfrom
Open
security: pin GitHub Actions to commit SHAs and add audit workflow#830rogerkorantenng wants to merge 1 commit intorust-lang:masterfrom
rogerkorantenng wants to merge 1 commit intorust-lang:masterfrom
Conversation
- Pin actions/checkout@v6 to v6.0.2 SHA (7 instances) - Pin actions/upload-artifact@v4 to v4.6.2 SHA - Pin actions/download-artifact@v4 to v4.3.0 SHA - Pin rust-lang/simpleinfra@master to specific commit SHA - Add persist-credentials: false to all checkout actions - Add zizmor-audit.yml workflow for continuous security monitoring - Add job names to conclusion jobs for better observability Fixes all HIGH severity zizmor issues (9 → 0). Uses pedantic persona for comprehensive security analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all HIGH severity zizmor security issues in crater's GitHub Actions workflows by pinning actions to commit SHAs and adds a preventive audit workflow.
Changes
Security Fixes (9 HIGH severity issues → 0)
actions/checkout@v6to v6.0.2 SHA (7 instances across ci.yml, pr.yml, zizmor-audit.yml)actions/upload-artifact@v4to v4.6.2 SHA (ci.yml)actions/download-artifact@v4to v4.3.0 SHA (ci.yml)rust-lang/simpleinfra@masterto specific commit SHA (ci.yml) - Critical: this action receives AWS credentialspersist-credentials: falseto all 6 checkout actions to prevent credential leakagePreventive Measures
.github/workflows/zizmor-audit.ymlworkflow for continuous security monitoringCode Quality
name: Conclusionto conclusion jobs in ci.yml and pr.yml for better observabilityValidation
zizmor --pedantic(exit code 13, 0 HIGH issues)actto simulate GitHub Actions executionRemaining Issues (Non-blocking)
13 MEDIUM severity issues remain (excessive-permissions, secrets-outside-env):
These are documented but not fixed as they require architectural changes beyond the scope of security fixes.
This PR is part of an Outreachy contribution to improve GitHub Actions security across rust-lang repositories.