Merged
Conversation
6abc2cc to
965de03
Compare
Member
|
Seems like you forgot to update a docker file. |
Member
Author
can you see the actual error? I seem to miss it in the logs |
Member
|
No, just: So I just assumed (maybe incorrectly) that a docker image needed to be updated. |
Member
Author
|
odd. I'll try locally |
Member
Author
|
ah, I think I know why |
Member
Author
|
I used the metrics endpoints as health-checks for most containers :) |
Member
|
So I was right, yeay me. \o/ |
GuillaumeGomez
approved these changes
Dec 2, 2025
Member
|
Looks good to me, thanks! |
Member
Author
I'll still wait until CI passes :) |
Member
Author
|
just confirmed again by @marcoieni : rust-lang/simpleinfra#832 is applied, the collectors don't collect any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs rust-lang/simpleinfra#832 to be merged & applied before deploying, so the collector doesn't run wild.thanks @marcoieni !This also removes the "crates / releases / targets visited" metrics. I didn't look at them for quite some time. There was an initial learning we had (= most requests are crawlers), but nothing else after that, so we can safe the processing time & memory.
If we feel like adding it back, we easily can.