Deprioritize older releases when new ones are added and refactor get_new_crates method#3065
Merged
syphar merged 2 commits intorust-lang:mainfrom Dec 10, 2025
Merged
Conversation
github-actions
bot
added
the
S-waiting-on-review
Carbonhell
commented
Dec 4, 2025
Carbonhell
force-pushed
the
tweak/deprioritize-older-releases
branch
2 times, most recently
from
744ab80 to
308726c
Compare
syphar
requested changes
Dec 5, 2025
refactor(queue): break up get_new_crates() in smaller methods to facilitate testing
chore(tracing): update tracing macro usages to use structured fields instead of string interpolation
Carbonhell
force-pushed
the
tweak/deprioritize-older-releases
branch
from
7607323 to
75575bc
Compare
syphar
reviewed
Dec 10, 2025
| ) -> Result<bool> { | ||
| match change { | ||
| Change::Added(release) => self.process_version_added(conn, release, registry).await?, | ||
| Change::AddedAndYanked(release) => { |
Member
There was a problem hiding this comment.
there is still a difference in error handling compared to before, for this variant.
old behaviour: we would still process the yank change, even when the "added" event failed.
New behaviour wouldn't do it.
But looking at past sentry errors I think we're good.
syphar
approved these changes
Dec 10, 2025
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3064 .
To facilitate testing, I decided to split up the
get_new_cratesmethod in smaller units. The actual change that updates the priority for older releases is contained in thedeprioritize_other_releasesmethod, which is called when only a new crate is processed. This logic is only invoked when processing new crate versions are found by the registry watcher.For the refactor, a point worthy of note relates to the removal of manual
report_errorcalls, in favor of propagating the error to the caller, since they're already reported in the registry watcher entrypoint - this does not include calls todeprioritize_other_releasesandqueue_crate_invalidation, for which a failure can be logged without killing the watcher.The tests introduced are quite simple - let me know if more are needed!