make static cache policy explicit, disable caching for objects >100 MiB#3067
Merged
syphar merged 2 commits intorust-lang:mainfrom Dec 5, 2025
Merged
make static cache policy explicit, disable caching for objects >100 MiB#3067syphar merged 2 commits intorust-lang:mainfrom
syphar merged 2 commits intorust-lang:mainfrom
Conversation
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
dont-cache-big-objects
branch
from
b71f93c to
c8109b8
Compare
marcoieni
reviewed
Dec 5, 2025
Member
|
looks good! |
syphar
force-pushed
the
dont-cache-big-objects
branch
from
c8109b8 to
4db2505
Compare
Co-authored-by: Marco Ieni <11428655+marcoieni@users.noreply.github.com>
GuillaumeGomez
approved these changes
Dec 5, 2025
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to download bigger archives, I saw some errors:
or
After a little digging I saw that the connection between fastly & nginx is cut after streaming exactly 100 MiB,
which made me think about limits :)
Then :
For now I chose to just forbid caching when the file is too big, segmented caching would be a little more effort, with IMO limited short-term gain. These archives aren't downloaded that often.