extract builder logic into new builder binary crate#3106
Merged
syphar merged 1 commit intorust-lang:mainfrom Dec 27, 2025
Merged
extract builder logic into new builder binary crate#3106syphar merged 1 commit intorust-lang:mainfrom
syphar merged 1 commit intorust-lang:mainfrom
Conversation
f5a843b to
9a971f7
Compare
9a971f7 to
d3e7853
Compare
d3e7853 to
86e77f4
Compare
86e77f4 to
98d36de
Compare
GuillaumeGomez
approved these changes
Dec 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also
CompressionAlgorithmtodocs_rs_typescrate.db::add_packageintodocs_rs_databasecrate.blacklist)doc_coveragetypes & parsing into_typescrateConfig&Contextstructs, with some conversionin between, not migrating all the old code.
I want to move these into "integration tests" which stay at the root of our
project, when the migration of the other parts is finished. But IMO that's easier to do when the test-environment etc is more fleshed out.
I probably need to move them to shared crates when I start migrating the other
binaries later.
build_queueandqueue_builderin the builder are just a MVP, a better structure is possible, but I want to do this separately.TestEnvironment,or if I want to merge these.
cratesfyibinary. Like thisI can start playing around with the new builder on the server without breaking
anything.
we will have a
docs_rs_cli(or_admin) binary for everything that justedits stuff in the database and the other services (web, watcher, builder)
just pick it up. Inside the watcher/builder binary itself we would do things
that need the full environment (index, build env, docker, ...).
old binary uses the new build-binary as library and calls its functions.