Skip to content

Introduce new TestEnvironment usable by all binary crates#3125

Merged
syphar merged 1 commit intorust-lang:mainfrom
syphar:shared-test-env
Jan 9, 2026
Merged

Introduce new TestEnvironment usable by all binary crates#3125
syphar merged 1 commit intorust-lang:mainfrom
syphar:shared-test-env

Conversation

@syphar
Copy link
Copy Markdown
Member

@syphar syphar commented Jan 9, 2026

  • migrate the test environment structs for all binary crates into a single one
  • library crates keep (for now) their smaller custom test envs
  • introduce AppConfig trait (needed for the shared test env), migrate all config structs to use it

smaller design changes:

  • TestEnvironment can Deref into Context, so some duplicated methods go away
  • some attributes on the TestEnvironment are now private, people need to use the deref or the accessor methods.

not in here, but I want to do it separately:

  • more config builders, currently test config building is all over the place
  • more docstrings / design explanation

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jan 9, 2026
@syphar syphar changed the title Shared test env Introduce new TestEnvironment usable by all binary crates Jan 9, 2026
@syphar syphar self-assigned this Jan 9, 2026
@syphar syphar force-pushed the shared-test-env branch 5 times, most recently from df65ff6 to 86333fc Compare January 9, 2026 12:16
@syphar syphar marked this pull request as ready for review January 9, 2026 12:17
@syphar syphar requested a review from a team as a code owner January 9, 2026 12:17
@syphar
Copy link
Copy Markdown
Member Author

syphar commented Jan 9, 2026

@GuillaumeGomez next refactor / cleanup :)

@syphar syphar merged commit b5cf266 into rust-lang:main Jan 9, 2026
14 checks passed
@syphar syphar deleted the shared-test-env branch January 9, 2026 12:24
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jan 9, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants