Open
Conversation
The single call site at regex-test/lib.rs:158 uses toml::from_str. In toml 0.9, from_str is now gated behind the serde feature (previously implicit); add "serde" to the crate's existing feature set ["parse"] to keep the same API available. The crate already depends on serde 1.0 with the derive feature, so the extra toml feature adds no new transitive dependency. Verified: cargo build -p regex-test cargo test -p regex-test cargo fmt --all --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
regex-test'stomldependency from0.8.14to0.9(stable since 2025-08-29).API change
toml::from_stris now gated behind theserdefeature in toml 0.9 (it was available under theparsefeature alone in 0.8). Added"serde"to the existingfeatures = ["parse"]list.regex-testalready depends onserde 1.0withderive, so enabling toml'sserdefeature adds no new transitive dependency.Single call site:
regex-test/lib.rs:158,toml::from_str(&data).Verification
cargo build -p regex-test: cleancargo test -p regex-test: 0 passed, 1 ignored, 0 failed (matches master behaviour)cargo fmt --all --check: cleanThe workspace's
cargo clippy --all-targets -- -D warningsrun has 70 pre-existing errors on master (reproducible on vanilla master before this change), unrelated to the bump.Context
Part of the Debian Rust team's
toml 0.9transition (debcargo-conf#147).regex-testis listed as a reverse-dependency.