[DO NOT MERGE] Permit bare fcp merge if there's only a single T-* team label#345
Draft
jieyouxu wants to merge 2 commits intorust-lang:masterfrom
Draft
[DO NOT MERGE] Permit bare fcp merge if there's only a single T-* team label#345jieyouxu wants to merge 2 commits intorust-lang:masterfrom
jieyouxu wants to merge 2 commits intorust-lang:masterfrom
Conversation
... with no explicit team list. Previously, when no explicit team list is specified, we unconditionally rejected bare `fcp merge` syntactically. The error message in the posted comment said > Provided team `` is invalid which doesn't help the FCP proposer figure out what's wrong. This test currently fails.
Defer the "no explicit team list" check until the github nag check for multiple team labels mandating team list specification. Previously, we would reject bare `@rfcbot fcp merge` _syntactically_ based on absence of explicit team list unconditionally. Now, the behavior is that: - In situation where there is exactly 1 `T-*` team label, `@rfcbot fcp merge` is permitted as a convenience fast-path, since this is unambiguous (for the most part). - When there are more than 1 `T-*` team labels, `@rfcbot fcp merge` is rejected, since it's usually not clear if _all_ the teams corresponding to the `T-*` labels should be involved in the FCP, or only a single team, or only a subset of teams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
The design of this needs some more discussion (thread: #t-infra > rfcbot down? @ 💬), should not be merged before that. Two things:
split(",")even on empty team list, which still correspond to 1 iteration of the empty string as-is. That empty string then obviously isn't a valid team, so we produce an comment complaining that "``" is not a valid team. This feels unintentional and more of a bug.