WIP: IntoIterator for Box<[T]> + method dispatch mitigation for editions < 2024#116607
Closed
clarfonthey wants to merge 2 commits intorust-lang:masterfrom
Closed
WIP: IntoIterator for Box<[T]> + method dispatch mitigation for editions < 2024#116607clarfonthey wants to merge 2 commits intorust-lang:masterfrom
clarfonthey wants to merge 2 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP: rust-lang/libs-team#263
References #59878
Recommendation per ACP: this should receive a crater run to gauge impact. If there's no impact, it can be merged as-is, but otherwise it will need a similar edition-based workaround to the array implementation.
In addition to what was proposed by the ACP, this also adds
IntoIterator for &Box<[T]>andIntoIterator for &mut Box<[T]>to ensure that those work as expected. I also already had to change at least one line in the compiler to account for this change, which isn't a good sign toward whether edition-specific mitigations may be needed, but we'll see.