Implement default_could_be_derived and default_overrides_default_fields lints#134441
Closed
estebank wants to merge 1 commit intorust-lang:masterfrom
Closed
Implement default_could_be_derived and default_overrides_default_fields lints#134441estebank wants to merge 1 commit intorust-lang:masterfrom
default_could_be_derived and default_overrides_default_fields lints#134441estebank wants to merge 1 commit intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect when a manual
Defaultimplementation isn't using the existing default field values and suggest using..instead:Detect when a manual
Defaultimplementation for a type containing at least one default field value has all fields that could be derived and suggest#[derive(Default)]:Store a mapping between the
DefIdfor animpl Default for Ty {}and theDefIdof either a Unit variant/struct or an fn with no arguments that is called within<Ty as Default>::default().When linting
impls, if it is forDefault, we evaluate the contents of theirfn default(). If it is only an ADT literal forSelfand every field is either a "known to be defaulted" value (0orfalse), an explicitDefault::default()call or a call or path to the same "equivalent"DefIdfrom that field's type'sDefault::default()implementation.