MaybeUninit inherent slice methods part 2#135394
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 20, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were moved out of #129259 since they require additional libs-api approval. Tracking issue: #117428.
New API surface:
Relevant motivation for these methods; see #129259 for earlier methods' motiviations.
write_filledsincefilledis being used as an object here, whereas it's being used as an action infill.write_withinstead ofwrite_filled_withsince it's shorter and still matches well.write_iterbecause it feels completely different from the fill methods, and still has the intent clear.In all of the methods, it felt appropriate to ensure that they contained
writeto clarify that they are effectively just special ways of doingMaybeUninit::writefor each element of a slice.Tracking issue: #117428
r? libs-api