Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves rust-lang/libs-team#330
Tracking issue: #135142
This is based on #135141, but I've reimplemented the UNIX version, which now:
sysconf(_SC_HOST_NAME_MAX)as an initial buffer lengthOutOfMemoryif theVecallocation failsgethostnamewas truncatedAdditionally, as part of the rebase, I had to move some WinSock abstractions (initialisation and error access) to
sys::palso that they can be accessed fromsys::net::hostname.CC @orowith2os (and thank you for your work!)