Rollup of 22 pull requests#154384
Conversation
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
* tests(ui): migrate issues/issue-17546 to ui/resolve * tests(ui): add gh issue link * tests(ui/issues): move tests to variants dir
There are many!
It's imported and can be used directly within this file, and already is in a few places.
A few can be done with the `impl_erasable_for_single_lifetime_types!` macro instead of being hand-written.
Using '_ removes unnecessary differences between the impl type and the associated `Storage` type.
Now that 'static lifetimes aren't used, a lot of the hand-written `Erasable` impls can now be done with the macro. (The only ones that can't are those with a generic type parameter, because `size_of` doesn't work in that case.) Also, `impl_erasable_for_single_lifetime_types!` isn't needed at all.
Some of the hand-written `Erasable` impls only match a single type in practice. It's easier to just list the concrete types in `impl_erasable_for_types_with_no_type_params!`.
|
@bors r+ rollup=never p=5 |
|
Trying commonly failed jobs |
This comment has been minimized.
This comment has been minimized.
Rollup of 22 pull requests try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 212ef77 (parent) -> 80d0e4b (this PR) Test differencesShow 272 test diffsStage 1
Stage 2
(and 58 additional test diffs) Additionally, 114 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 80d0e4be6f15899649ba31669077c59a986f96cc --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (80d0e4b): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.8%, secondary -0.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.5%, secondary 3.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 1.7%, secondary 1.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 484.064s -> 481.885s (-0.45%) |
|
I checked the before/after helloworld binaries, and the binary size seems to be increased from additional debuginfo stuff. So I place my bet on #154468. |
|
#154468 explains some but not nearly all of the perf regression |
Successful merges:
-Zsanitize=kernel-hwaddress#153049 (Add-Zsanitize=kernel-hwaddress)guardfragment specifier #153702 (Add macro matcher forguardfragment specifier)self_declwith a correct visibility #154313 (Initself_declwith a correct visibility)Erasableimpls #154351 (OverhaulErasableimpls)GrowableBitSet#151148 (Add functions toGrowableBitSet)tests/ui/macroscleanup #154112 (sometests/ui/macroscleanup)tests/ui/structs-enumscleanup #154131 (begintests/ui/structs-enumscleanup)NonNull::with_exposed_provenanceas const #154216 (unstably markNonNull::with_exposed_provenanceas const)char::to_titlecase#154288 (Fix typo in doc comment forchar::to_titlecase)signextfor argument #154360 (fromrangeiter-overflow-checks: accept optionalsignextfor argument)r? @ghost
Create a similar rollup