Rollup of 5 pull requests by chenyukang · Pull Request #154659 · rust-lang/rust

chenyukang · 2026-04-01T02:43:57Z

Successful merges:

c-variadic: error when we can't guarantee that the backend does the right thing #152935 (c-variadic: error when we can't guarantee that the backend does the right thing)
std::net: clamp linger timeout value to prevent silent truncation. #153207 (std::net: clamp linger timeout value to prevent silent truncation.)
Fix mismatched_lifetime_syntaxes suggestions for hidden path lifetimes #154592 (Fix mismatched_lifetime_syntaxes suggestions for hidden path lifetimes)
fix pin docs #154643 (fix pin docs)
Clarify ty::List #154648 (Clarify ty::List)

Duration::as_secs() returns u64 but l_linger field type is narrower, c_int on most unix platforms, c_ushort on cygwin and windows. clamping before the cast, consistent with how set_timeout handles this.

Checking that they really do use thin pointers.

- Add some explanatory comments. - Rename `OpaqueListContents` as `ExternTy`. I've always found both the "opaque" and "contents" parts of this name to be confusing. Calling it `ExternTy` makes it clear that all that matters is it's an extern type.

- Merge the `List` and `ListWithCachedTypeInfo` impls by referring to the shared underlying type, `RawList`. This required increasing the visibility of `RawList`. - Explain why a separate impl is needed for `RawList`. - Remove an incorrect FIXME comment. Fat reference types will always need a separate impl. (To be sure, one could use `T: ?Sized` to merge the impls for `&T` and `&[T]` and it would compile but it would behave incorrectly because `&T` needs one word of storage and `&[T]` needs two words of storage. I tried it and it did not go well.)

…ight thing specifically this emits an error when - a custom target is used - `RiscV32 if self.llvm_abiname == "ilp32e"` this abi is used for 32-bit embedded targets, and clang/llvm document that the ABI may change in the future.

…tgross35 c-variadic: error when we can't guarantee that the backend does the right thing tracking issue: rust-lang#44930 r? workingjubilee as discussed in [#t-lang > stabilizing &rust-lang#96;c_variadic&rust-lang#96;](https://rust-lang.zulipchat.com/#narrow/channel/213817-t-lang/topic/stabilizing.20.60c_variadic.60/with/574691397), display an error when we can't guarantee that the codegen backend (only LLVM is supported at the moment) does the right thing.

…nieu std::net: clamp linger timeout value to prevent silent truncation. Duration::as_secs() returns u64 but l_linger field type is narrower, c_int on most unix platforms, c_ushort on cygwin and windows. clamping before the cast, consistent with how set_timeout handles this.

@chenyukang

Fix `mismatched_lifetime_syntaxes` suggestions for hidden path lifetimes close: rust-lang#154493 r? shepmaster cc: @chenyukang

fix pin docs This PR fixes a small grammatical error in the projection section of the pin docs. There is probably more than one answer for the fix, but I felt that this correction was the *smallest*.

@cuviper

…iper Clarify `ty::List` `ty::List` is an unusual type. This commit clarifies some things about it. Details in individual commits. r? @cuviper

chenyukang · 2026-04-01T02:44:07Z

@bors r+ rollup=never p=5

rust-bors · 2026-04-01T02:44:16Z

📌 Commit 18f8cd2 has been approved by chenyukang

It is now in the queue for this repository.

rust-bors · 2026-04-01T08:58:08Z

☀️ Test successful - CI
Approved by: chenyukang
Duration: 3h 10m 6s
Pushing 3ebe60c to main...

rust-timer · 2026-04-01T08:59:36Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#152935	c-variadic: error when we can't guarantee that the backend …	`e0e70fdb62f6516c9c3a99758564beb70f79d0e7` (link)
#153207	std::net: clamp linger timeout value to prevent silent trun…	`4c52b6b80fde780a09e22b3c8f124d176edec52e` (link)
#154592	Fix `mismatched_lifetime_syntaxes` suggestions for hidden p…	`a6d4b2dd6b2db6d5acea11a13a592c46a7dc6755` (link)
#154643	fix pin docs	`3b697077df00afcd59cf23b9dcbeec48723c1fd8` (link)
#154648	Clarify `ty::List`	`7f3547e7e9d6934b539b06d03592dc49929e037b` (link)

previous master: 12ab1cf1fd

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-04-01T09:01:05Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 12ab1cf (parent) -> 3ebe60c (this PR)

Test differences

Show 34 test diffs

Stage 1

[ui] tests/ui/lifetimes/mismatched-lifetime-syntaxes-details/macro.rs: [missing] -> pass (J0)
[ui] tests/ui/lifetimes/mismatched-lifetime-syntaxes-details/mismatched-lifetime-syntaxes.rs: [missing] -> pass (J0)
[ui] tests/ui/lifetimes/mismatched-lifetime-syntaxes-details/path-count.rs: [missing] -> pass (J0)
[ui] tests/ui/lifetimes/mismatched-lifetime-syntaxes.rs: pass -> [missing] (J0)

Stage 2

[ui] tests/ui/lifetimes/mismatched-lifetime-syntaxes-details/macro.rs: [missing] -> pass (J1)
[ui] tests/ui/lifetimes/mismatched-lifetime-syntaxes-details/mismatched-lifetime-syntaxes.rs: [missing] -> pass (J1)
[ui] tests/ui/lifetimes/mismatched-lifetime-syntaxes-details/path-count.rs: [missing] -> pass (J1)
[ui] tests/ui/lifetimes/mismatched-lifetime-syntaxes.rs: pass -> [missing] (J1)

Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3ebe60c8c30d1175019dcbdb957441cd84aa1220 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 2h 33m -> 3h 1m (+17.8%)
dist-aarch64-apple: 1h 56m -> 1h 37m (-16.2%)
dist-x86_64-freebsd: 1h 23m -> 1h 34m (+13.5%)
dist-various-1: 1h 4m -> 1h 12m (+12.3%)
dist-apple-various: 1h 34m -> 1h 43m (+10.0%)
dist-ohos-x86_64: 1h 19m -> 1h 11m (-9.5%)
dist-x86_64-apple: 1h 45m -> 1h 54m (+9.4%)
x86_64-msvc-ext1: 2h 14m -> 2h 2m (-9.0%)
aarch64-gnu-llvm-21-1: 56m 5s -> 1h 1m (+8.9%)
x86_64-gnu-miri: 1h 25m -> 1h 33m (+8.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-04-01T09:39:53Z

Finished benchmarking commit (3ebe60c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.1%, -0.2%]	10
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-1.1%, -0.2%]	10

Max RSS (memory usage)

Results (primary 2.5%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.4%, 4.2%]	4
Regressions ❌ (secondary)	1.7%	[1.6%, 1.8%]	2
Improvements ✅ (primary)	-1.2%	[-1.2%, -1.2%]	1
Improvements ✅ (secondary)	-4.1%	[-4.1%, -4.1%]	1
All ❌✅ (primary)	2.5%	[-1.2%, 4.2%]	5

Cycles

Results (secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.2%	[2.3%, 6.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 482.203s -> 483.835s (0.34%)
Artifact size: 394.92 MiB -> 394.92 MiB (-0.00%)

devnexen and others added 14 commits February 28, 2026 07:02

std::net: clamp linger timeout value to prevent silent truncation.

baf8595

Duration::as_secs() returns u64 but l_linger field type is narrower, c_int on most unix platforms, c_ushort on cygwin and windows. clamping before the cast, consistent with how set_timeout handles this.

Move mismatched lifetime syntax tests into details

e5c6f7a

Fix mismatched_lifetime_syntaxes suggestions for hidden path lifetimes

25dbba0

Pluralize hidden lifetime labels

8cef68a

fix pin docs

9626ca2

Add some size assertions for List/RawList.

f334357

Checking that they really do use thin pointers.

Clarify use of extern type in RawList.

0f159dc

- Add some explanatory comments. - Rename `OpaqueListContents` as `ExternTy`. I've always found both the "opaque" and "contents" parts of this name to be confusing. Calling it `ExternTy` makes it clear that all that matters is it's an extern type.

Rollup merge of rust-lang#154592 - reddevilmidzy:lifetime, r=chenyukang

1f5dcf3

Fix `mismatched_lifetime_syntaxes` suggestions for hidden path lifetimes close: rust-lang#154493 r? shepmaster cc: @chenyukang

Rollup merge of rust-lang#154643 - AdinAck:fix-pin-docs, r=chenyukang

9344df3

fix pin docs This PR fixes a small grammatical error in the projection section of the pin docs. There is probably more than one answer for the fix, but I felt that this correction was the *smallest*.

Rollup merge of rust-lang#154648 - nnethercote:clarify-ty-List, r=cuv…

18f8cd2

…iper Clarify `ty::List` `ty::List` is an unusual type. This commit clarifies some things about it. Details in individual commits. r? @cuviper

rust-bors bot added the rollup A PR which is a rollup label Apr 1, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2026

rust-bors bot merged commit 3ebe60c into rust-lang:main Apr 1, 2026
12 checks passed

rustbot added this to the 1.96.0 milestone Apr 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests#154659

Rollup of 5 pull requests#154659
rust-bors[bot] merged 14 commits intorust-lang:mainfrom
chenyukang:rollup-D1UvH9O

chenyukang commented Apr 1, 2026

Uh oh!

chenyukang commented Apr 1, 2026

Uh oh!

rust-bors bot commented Apr 1, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 1, 2026

Uh oh!

Uh oh!

rust-timer commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

chenyukang commented Apr 1, 2026

Uh oh!

chenyukang commented Apr 1, 2026

Uh oh!

rust-bors bot commented Apr 1, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 1, 2026

Uh oh!

Uh oh!

rust-timer commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Apr 1, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants