Auto-assign, label, and CC lang-docs (+FLS) and edition - #158424
Auto-assign, label, and CC lang-docs (+FLS) and edition#158424traviscross wants to merge 1 commit into
Conversation
The documentation on primitives, attributes, and keywords is language documentation and should be kept synchronized with the Reference. When these files are touched, let's add the `T-lang-docs` label, CC the team (and the FLS team), and assign the issue to a team member. (For attribute documentation, we'll also include Guillaume in the rotation as he's been working on this.) For bandwidth reasons, we may still reroll assignment to libs or compiler for ordinary matters. We'll see. The `primitive_docs.rs` file churns the most and is the one we'd be most likely to hand back. When the submodule pointer for a book owned by lang-docs or edition is updated, let's CC the team and add the correct label. For edition, we want changes to `compiler/rustc_span/src/edition.rs` and the tests in `tests/ui/editions` to cause the `T-edition` label to be applied and the team to be pinged; this arranges for that as well.
traviscross
added
T-lang-docs
rustbot
added
A-meta
|
☔ The latest upstream changes (presumably #159579) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
There was a problem hiding this comment.
I'm personally happy to see this happen. I think we can see how responsive lang-docs is in practice (i.e., what the tradeoff is on contributor experience from a smaller group being the primary assignee). I think long-term the right path is probably for lang-relevant aspects of this to move out to the reference or other material, but for now it seems fine.
(Essentially my short take is that if lang-docs wants to help with a subset of reviews that seems totally reasonable to me).
Nominating for libs in case there are any objections.
@rustbot label +I-libs-nominated
|
|
||
| [mentions."src/doc/nomicon"] | ||
| message = "A language documentation submodule was updated." | ||
| cc = ["@rust-lang/lang-docs"] |
There was a problem hiding this comment.
I don't know how much value there is in this since the changes have already been reviewed upstream in the nomicon (and same for the reference below).
There was a problem hiding this comment.
Yes, I was on the fence about this part too. The risk of noise isn't so much from the intended submodule bumps as from where people accidentally bump it on unrelated PRs.
rustbot
added
the
I-libs-nominated
|
Per today's libs meeting, we're okay with this so long as it's just those three files being touched ^^ thanks! |
nia-e
removed
the
I-libs-nominated
5 participants
The documentation on primitives, attributes, and keywords is language documentation and should be kept synchronized with the Reference. When these files are touched, let's add the
T-lang-docslabel, CC the team (and the FLS team), and assign the issue to a team member. (For attribute documentation, we'll also include Guillaume in the rotation as he's been working on this.)For bandwidth reasons, we may still reroll assignment to libs or compiler for ordinary matters. We'll see. The
primitive_docs.rsfile churns the most and is the one we'd be most likely to hand back.When the submodule pointer for a book owned by lang-docs or edition is updated, let's CC the team and add the correct label.
For edition, we want changes to
compiler/rustc_span/src/edition.rsand the tests intests/ui/editionsto cause theT-editionlabel to be applied and the team to be pinged; this arranges for that as well.r? ehuss
cc @rust-lang/lang-docs @rust-lang/fls @rust-lang/edition