Skip to content

Move std::io::buffered to alloc::io#158547

Open
bushrat011899 wants to merge 7 commits into
rust-lang:mainfrom
bushrat011899:alloc_io_buffered
Open

Move std::io::buffered to alloc::io#158547
bushrat011899 wants to merge 7 commits into
rust-lang:mainfrom
bushrat011899:alloc_io_buffered

Conversation

@bushrat011899

Copy link
Copy Markdown
Contributor

ACP: rust-lang/libs-team#755
Tracking issue: #154046
Split From: #156527
Blocked On: #158546

Description

Moves std::io::BufReader/BufWriter/LineWriter/etc. to alloc::io. This is effectively a direct cut and paste. Blocked on #158546.


Notes

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 29, 2026
@rustbot

rustbot commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from 6 candidates

@rustbot rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jun 29, 2026
@bushrat011899

Copy link
Copy Markdown
Contributor Author

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2026
@rust-bors

This comment has been minimized.

@rustbot

This comment has been minimized.

@bushrat011899
bushrat011899 force-pushed the alloc_io_buffered branch 2 times, most recently from dd63a8f to bc8b452 Compare July 3, 2026 03:48
@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@rustbot

This comment has been minimized.

None of the currently public methods are accessible outside `std`, and are unused within. Therefore, they can be restricted to internal use.
@rustbot

rustbot commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@clarfonthey

Copy link
Copy Markdown
Contributor

Just adding a reminder for review here: I think there was one of the public+unstable methods that would no longer need to be public with this change, but I might just be misremembering and should look into it when I get to reviewing this.

Also, r? clarfonthey

@rustbot rustbot assigned clarfonthey and unassigned JohnTitor Jul 19, 2026
@bushrat011899

Copy link
Copy Markdown
Contributor Author

Just adding a reminder for review here: I think there was one of the public+unstable methods that would no longer need to be public with this change, but I might just be misremembering and should look into it when I get to reviewing this.

No you're remembering correctly! I've updated this PR to ensure anything exported from alloc::io privately is actually used within std, and likewise for core::io and alloc. I'll note here that DEFAULT_BUF_SIZE, default_read_buf, default_read_vectored, and default_write_vectored are appropriately marked as allow(unused_imports) as they are only used within std::sys for certain targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants