Move std::io::buffered to alloc::io#158547
Conversation
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@rustbot blocked |
This comment has been minimized.
This comment has been minimized.
999bae7 to
ed009e7
Compare
This comment has been minimized.
This comment has been minimized.
dd63a8f to
bc8b452
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bc8b452 to
62c2a52
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
62c2a52 to
29b77fb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
29b77fb to
a70a3c2
Compare
This comment has been minimized.
This comment has been minimized.
a70a3c2 to
f266f4c
Compare
This comment has been minimized.
This comment has been minimized.
f266f4c to
e5311db
Compare
This comment has been minimized.
This comment has been minimized.
e5311db to
b6340ed
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b6340ed to
e0e18d6
Compare
This comment has been minimized.
This comment has been minimized.
None of the currently public methods are accessible outside `std`, and are unused within. Therefore, they can be restricted to internal use.
e0e18d6 to
a2a5670
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Just adding a reminder for review here: I think there was one of the public+unstable methods that would no longer need to be public with this change, but I might just be misremembering and should look into it when I get to reviewing this. Also, r? clarfonthey |
No you're remembering correctly! I've updated this PR to ensure anything exported from |
ACP: rust-lang/libs-team#755
Tracking issue: #154046
Split From: #156527
Blocked On: #158546
Description
Moves
std::io::BufReader/BufWriter/LineWriter/etc. toalloc::io. This is effectively a direct cut and paste. Blocked on #158546.Notes
alloc::ioandcore::io#154046 (comment) for a review order and broader context for this PR.