Shrink ast::Expr64

[nnethercote]

View all comments

From 72 bytes to 64 bytes, by boxing ForLoop, which is the biggest
variant.

There are now 11 ExprKind variants that are 31 bytes, so future
improvements here will be very difficult.

[nnethercote]

@bors try @rust-timer queue

[nnethercote]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 05fc14a (05fc14a7ef6f521e0ff88a111b396eb0d1729253)
Base parent: c397dae (c397dae808f70caebab1fc4e11b3edf7e59f58c7)

[nnethercote]

@bors try @rust-timer queue

[rust-bors]

💔 Test for 586eb5f failed: CI. Failed job:

• auto - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

[JonathanBrouwer]

@bors retry

[JonathanBrouwer]

@bors p=6
Scheduling

[theemathas]

@bors yield
(Giving priority to the retry of the 1.97.1 release at #159288)

[rust-bors]

Auto build was cancelled. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/29344116262

The next pull request likely to be tested is #159288.

[rust-bors]

💔 Test for b3166eb failed: CI. Failed job:

• auto - x86_64-msvc-ext1 (web logs, enhanced plaintext logs)

[JonathanBrouwer]

@bors retry

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  WIX: /d/a/rust/rust/wix
##[endgroup]
    Updating crates.io index
error: failed to get `askama_derive` as a dependency of package `askama_macros v0.16.0`
    ... which satisfies dependency `askama_macros = "=0.16.0"` of package `askama v0.16.0`
    ... which satisfies dependency `askama = "^0.16.0"` of package `citool v0.1.0 (D:\a\rust\rust\src\ci\citool)`

Caused by:
  failed to load source for dependency `askama_derive`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of as/ka/askama_derive failed

Caused by:
  curl failed

Caused by:

[rust-bors]

☀️ Test successful - CI
Approved by: folkertdev
Duration: 3h 28m 10s
Pushing 470556c to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 38a0576 (parent) -> 470556c (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 470556c8c1c21a736c90deea5c70d093ffa4e762 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. i686-gnu-nopt-1: 1h 50m -> 2h 25m (+30.8%)
2. pr-check-2: 39m 40s -> 28m 45s (-27.5%)
3. dist-x86_64-illumos: 1h 23m -> 1h 46m (+27.2%)
4. i686-msvc-2: 1h 59m -> 1h 29m (-24.7%)
5. x86_64-gnu-llvm-21-3: 1h 58m -> 1h 29m (-24.5%)
6. dist-x86_64-msvc: 1h 35m -> 1h 58m (+23.5%)
7. dist-aarch64-apple: 1h 39m -> 2h 2m (+23.4%)
8. x86_64-gnu-llvm-21: 1h 19m -> 1h 1m (-23.1%)
9. x86_64-mingw-1: 3h 6m -> 2h 23m (-22.8%)
10. x86_64-gnu-aux: 2h 13m -> 2h 41m (+20.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (470556c): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

• If the regression was expected or you think it can be justified,
  please write a comment with sufficient written justification, and add
  @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
• If you think that you know of a way to resolve the regression, try to create
  a new PR with a fix for the regression.
• If you do not understand the regression or you think that it is just noise,
  you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
  were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.3%, 0.6%]	3
Regressions ❌ (secondary)	0.6%	[0.3%, 1.3%]	25
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.3%, 0.6%]	3

Max RSS (memory usage)

Results (primary -0.5%, secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.7%, 2.1%]	7
Regressions ❌ (secondary)	5.5%	[2.1%, 10.4%]	15
Improvements ✅ (primary)	-2.9%	[-5.4%, -0.5%]	5
Improvements ✅ (secondary)	-5.1%	[-10.2%, -0.6%]	14
All ❌✅ (primary)	-0.5%	[-5.4%, 2.1%]	12

Cycles

Results (primary -1.6%, secondary -6.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[3.9%, 3.9%]	1
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-7.1%	[-13.0%, -3.2%]	13
All ❌✅ (primary)	-1.6%	[-1.6%, -1.6%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.951s -> 490.163s (0.04%)
Artifact size: 389.41 MiB -> 389.94 MiB (0.14%)