rustc_passes: lint unused `#[path]` attributes on inline modules by ravlynd · Pull Request #158835 · rust-lang/rust

ravlynd · 2026-07-06T03:31:40Z

View all comments

Closes #157260.

This PR emits the unused_attributes lint for #[path] attributes on inline modules when the attribute is unused.

It also adds UI tests covering both linted and non-linted cases.

r? @theemathas

rustbot · 2026-07-06T03:31:43Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-07-06T03:31:45Z

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @theemathas (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

theemathas · 2026-07-06T03:32:45Z

r? compiler

hanna-kruppe · 2026-07-06T22:02:16Z

This feels similar-ish to other warnings about misapplied attributes, at least some of which were treated more as FCW than regular warning. Maybe there's a reason I'm missing why this one should be different. @JonathanBrouwer what do you think?

rustbot · 2026-07-07T17:26:33Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

hanna-kruppe · 2026-07-07T17:33:33Z

r? @JonathanBrouwer

rustbot · 2026-07-07T17:33:38Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

ravlynd · 2026-07-08T05:10:29Z

@rustbot ready

rust-bors · 2026-07-31T14:01:41Z

This pull request was unapproved.

View changes since this unapproval

ravlynd · 2026-08-08T02:51:51Z

@rustbot ready

JonathanBrouwer · 2026-08-08T14:20:17Z

@bors r+
Thanks <3

rust-bors · 2026-08-08T14:20:21Z

📌 Commit a7636e9 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 12 pull requests Successful merges: - #160336 (Move attributes out of rustc_hir) - #160715 (ignore tests with the GCC backend if we can't find `libgccjit.so` for the target) - #157609 (fix: build-std on 32 bit arm with 64 bit time) - #160613 (Add regression test for unsized non-last struct field with overlapping impls) - #160658 (miri: implement more restrictive trivial-ABI checks) - #160704 (sort lint names in lint pass declarations) - #160707 (Add regression test for higher ranked fn pointer impl not general enough) - #160713 (Add regression test for #135287) - #160720 (triagebot: add ubiratan to infra-ci) - #160747 (rustc_errors: remove unused code) - #160751 (Add regression test for incremental borrowck ICE with generic const exprs) - #160753 (rustc_lint: remove unused rustc_attrs feature) Failed merges: - #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules)

rustbot · 2026-08-08T20:16:05Z

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-08-08T20:16:07Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-08-08T20:16:26Z

^ Rebased
@bors r+

rust-bors · 2026-08-08T20:16:29Z

📌 Commit 7b1731b has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 9 pull requests Successful merges: - #156935 (Introduce a `PinSafePointer` trait that generalizes `PinCoerceUnsized`) - #159834 (Apply str debugger visualizer to `*const str`, `*mut str` and `Box<str>`) - #160663 (Suggest add async for function sig with return expr in body) - #160732 (Optimize slice::contains for one-byte BytewiseEq types) - #157944 (Make `char::is_default_ignorable` unstably public) - #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules) - #160754 (Rename more diagnostic files to `diagnostics.rs`) - #160755 (Merge `rustc_lint/lints.rs` into `diagnostics.rs`) - #160757 (Merge `rustc_attr_parsing/session_diagnostics.rs` into `diagnostics.rs`)

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 6, 2026

rustbot assigned theemathas Jul 6, 2026

rustbot assigned hanna-kruppe and unassigned theemathas Jul 6, 2026

JonathanBrouwer requested changes Jul 7, 2026

View reviewed changes

Comment thread compiler/rustc_passes/src/diagnostics.rs Outdated

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 7, 2026

rustbot assigned JonathanBrouwer and unassigned hanna-kruppe Jul 7, 2026

ravlynd force-pushed the fix/warn-path-attribute branch from c397ba1 to 37c3b37 Compare July 8, 2026 04:51

This comment has been minimized.

Sign in to view

ravlynd changed the title ~~fix: emit diagnostic for useless #[path] attribute on inline modules~~ rustc_passes: lint unused #[path] attributes on inline modules Jul 8, 2026

ravlynd force-pushed the fix/warn-path-attribute branch from 37c3b37 to 56dd0c2 Compare July 8, 2026 04:59

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 8, 2026

ravlynd requested a review from JonathanBrouwer July 8, 2026 05:11

JonathanBrouwer approved these changes Jul 10, 2026

View reviewed changes

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 31, 2026

ravlynd force-pushed the fix/warn-path-attribute branch from d468a2b to 6d83fae Compare August 5, 2026 01:18

This comment has been minimized.

Sign in to view

ravlynd force-pushed the fix/warn-path-attribute branch from 6d83fae to a7636e9 Compare August 8, 2026 01:19

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 8, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2026

JonathanBrouwer mentioned this pull request Aug 8, 2026

Rollup of 12 pull requests #160761

Merged

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 8, 2026

This comment has been minimized.

Sign in to view

rustc_passes: lint unused #[path] attributes on inline modules

7b1731b

JonathanBrouwer force-pushed the fix/warn-path-attribute branch from a7636e9 to 7b1731b Compare August 8, 2026 20:16

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 8, 2026

JonathanBrouwer mentioned this pull request Aug 8, 2026

Rollup of 9 pull requests #160774

Merged

rust-bors Bot merged commit 2a8d31a into rust-lang:main Aug 9, 2026
13 checks passed

Uh oh!

Uh oh!

Conversation

ravlynd commented Jul 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

rustbot commented Jul 6, 2026

Uh oh!

theemathas commented Jul 6, 2026

Uh oh!

hanna-kruppe commented Jul 6, 2026

Uh oh!

Uh oh!

rustbot commented Jul 7, 2026

Uh oh!

hanna-kruppe commented Jul 7, 2026

Uh oh!

rustbot commented Jul 7, 2026

Uh oh!

This comment has been minimized.

ravlynd commented Jul 8, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ravlynd commented Aug 8, 2026

Uh oh!

JonathanBrouwer commented Aug 8, 2026

Uh oh!

rust-bors Bot commented Aug 8, 2026

Uh oh!

This comment has been minimized.

rustbot commented Aug 8, 2026

Uh oh!

rustbot commented Aug 8, 2026

Uh oh!

JonathanBrouwer commented Aug 8, 2026

Uh oh!

rust-bors Bot commented Aug 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

ravlynd commented Jul 6, 2026 •

edited by rustbot

Loading