x86: on targets that requires SSE, use those registers for ABI - #161583
Open
RalfJung wants to merge 1 commit into
Open
x86: on targets that requires SSE, use those registers for ABI#161583RalfJung wants to merge 1 commit into
RalfJung wants to merge 1 commit into
Conversation
RalfJung
force-pushed
the
x86-sse-abi
branch
2 times, most recently
from
August 23, 2026 10:33
7f487df to
06a4f6d
Compare
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Aug 23, 2026
RalfJung
force-pushed
the
x86-sse-abi
branch
2 times, most recently
from
August 23, 2026 11:45
a01a5dd to
7d66bd1
Compare
RalfJung
commented
Aug 23, 2026
Member
Author
|
@bors try jobs=i686,various |
Contributor
|
⌛ Trying commit 82b0b84 with merge a32c597… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/32642426825 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 23, 2026
x86: on targets that requires SSE, use those registers for ABI try-job: *i686* try-job: *various*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that llvm/llvm-project#142321 is fixed, we can use the vector ABI without re-introducing #139029. So this effectively reverts #141309.
This can lead to new hard errors on code that previously compiled if all of the following apply:
Also this will cause performance regressions on LLVM 22 and 21 as those don't have the fix for llvm/llvm-project#142321. IMO that's fine. Programs will do the right thing, they will just be a bit slower due to #139029.
@rust-lang/lang please let me know if you're fine with just landing this or if you want to apply some sort of process here. (We have just landed this the first time we tried to use SSE in the ABI, but back then I didn't think of the fact that in some unsupported corner cases, this can lead to new hard errors.) If you do think that this needs FCP, please let me know and I will propose that we turn the target-feature ABI check into a hard error on x86-32 (similar to #161280).
r? @nikic
Cc @tgross35