Consolidate LLVM skip in check builds in bootstrap - #161853
Open
Kobzol wants to merge 4 commits into
Open
Conversation
Its environment variables don't seem to be used for the codegen backends.
rustbot
added
A-testsuite
jieyouxu
approved these changes
Aug 27, 2026
Member
|
@bors rollup=never note="bootstrap llvm skip logic" |
Member
Author
|
@bors r=jieyouxu Let's try to land this and see if there aren't any issues. |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@bors r- |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. |
Member
Author
|
Surprise surprise, I didn't run bootstrap tests. |
jieyouxu
reviewed
Aug 27, 2026
| [build] llvm <host> | ||
| [clippy] rustc 0 <host> -> rustc 1 <host> | ||
| "); | ||
| .render_steps(), @"[clippy] rustc 0 <host> -> rustc 1 <host>"); |
Member
There was a problem hiding this comment.
And also don't have to build llvm for stage 1 clippy/fix on compiler tree, which makes sense
Member
Author
|
@bors r=jieyouxu |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before it was distributed amongst two places, which made it harder to follow the logic, and the
RUST_CHECKlogic was also applied for anything being built, even though it is only relevant for rustc itself. This PR centralizes the handling, and also enables it fordocbuilds.So
./x doc compilernow doesn't require building LLVM 🎉r? jieyouxu