Open
Conversation
bjorn3
reviewed
Apr 14, 2026
src/value_and_place.rs
Outdated
| CValueInner::ByRef(_, Some(_)) => todo!(), | ||
| CValueInner::ByRef(from_ptr, Some(_extra)) => { | ||
| // Unsized values shouldn't normally be written into sized places. However, | ||
| // if this happens, we can still copy the sized prefix using the destination layout's fixed size. |
Member
There was a problem hiding this comment.
If an IR invariant is violated, we should fail loudly, not silently do something that seems roughly correct, but almost certainly causes hard to debug corruption.
Author
|
Is “copy sized prefix when writing from |
bjorn3
reviewed
Apr 14, 2026
| } else { | ||
| CValue::by_ref(field_ptr, field_layout) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
The only places where value_field is used don't use unsized values afaik. It can always be implemented later if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added handling for unsized by-ref values (
CValueInner::ByRef(_, Some(meta)))inCValue::value_fieldand removes the remainingtodo!()crash paths insrc/value_and_place.rs. Forwrite_cvaluefrom an unsizedby-refinto a sized destination, it falls back to copying the sized prefix (destination’s fixed size) to avoid hard failures.