Open
Conversation
sayantn
reviewed
Mar 21, 2026
| - name: Aarch64 load/store roundtrip | ||
| env: | ||
| TARGET: "aarch64-unknown-linux-gnu" | ||
| run: cargo miri test -p core_arch --target aarch64-unknown-linux-gnu -- test_vld3q |
Contributor
There was a problem hiding this comment.
it might be nice to have a small .txt file with all the test names instead of having them inline. Also we can probably test more, the CI already takes 12 minutes, so we can increase this until the time reaches 12 minutes without slowing CI down at all
Contributor
Author
There was a problem hiding this comment.
Sure we have time (and could shard if not) but most of the other tests still fail because either the read or write does not use the portable intrinsic. This particular one is of interest for the backport of the UB fix in #t-libs/backports > #153336: beta-nominated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? sayantn
We briefly discussed testing with miri at some point, so I'm not sure if you had something specific in mind? This setup is not the most robust at the moment, but that is mostly because I'm running into missing Miri support very quickly.