turn merge queue into a struct to support config option#2344
Merged
Conversation
Dry-run check results |
marcoieni
commented
Mar 25, 2026
| }) | ||
| .collect(), | ||
| merge_queue: b.merge_queue, | ||
| merge_queue: b.merge_queue.enabled, |
Member
Author
There was a problem hiding this comment.
this allows to keep the v1 API retro compatible (at least for now)
marcoieni
requested review from
Mark-Simulacrum,
emilyalbini,
jdno and
ubiratansoares
as code owners
Kobzol
reviewed
Mar 25, 2026
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
It would be slightly nicer if we could just use merge-queue = true to use the defaults, rather than always having to expand the config, but that's not super important.
Member
Author
|
Having to support both |
ubiratansoares
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to allow people to configure merge queues (see #1735 (comment)).