fix: fix outdated config initialization (EndpointResolver) in Go SDK documentation #83
Open
ZureTz wants to merge 1 commit intorustfs:mainfrom
Open
fix: fix outdated config initialization (EndpointResolver) in Go SDK documentation #83ZureTz wants to merge 1 commit intorustfs:mainfrom
ZureTz wants to merge 1 commit intorustfs:mainfrom
Conversation
|
@ZureTz is attempting to deploy a commit to the overtrue's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Go SDK documentation for RustFS to configure the S3 client’s custom endpoint using the newer, non-deprecated approach in AWS SDK for Go v2.
Changes:
- Removes use of
aws.Config.EndpointResolverin the example configuration. - Sets the custom endpoint via
s3.NewFromConfigoptions (o.BaseEndpoint = aws.String(endpoint)).
You can also share your feedback on Copilot code review. Take the survey.
ZureTz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Go SDK documentation for configuring an S3 client, focusing on how the endpoint is set in the AWS configuration. Changed the way the custom endpoint is specified when creating the S3 client to the not deprecated one. (See here)