Add advisory for hugepage-rs dealloc unsoundness#2977
Open
sisy2020 wants to merge 1 commit into
Open
Conversation
Member
|
Waiting for maintainer response. Don't forget to include the crates.io recent download count in your PR descriptions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected crate(s)
hugepage-rs(5,405 recent downloads per crates.io)Links to upstream issue(s) or PR(s)
Severity
Soundness issue in a safe public API.
hugepage_rs::deallocaccepted an arbitrary raw pointer andLayout, then forwarded them toGlobalAlloc::dealloc, whose safety contract requires the pointer and layout to match an allocation from the same allocator.Safe callers could therefore trigger undefined behavior without using
unsafe.The issue was fixed upstream by marking
deallocasunsafe, and the fix has been published in0.1.1.Checklist
RUSTSEC-0000-0000as the IDdatefield is set to the public disclosure date