fix(release): drop --all-features from build-release step#75
Merged
Conversation
`cargo build --release --target X --all-features` on the midstream root crate enables the off-by-default `lean-agentic` feature, which exposes 27 unresolved-import errors in `src/lean_agentic/`. The v0.2.1 release run failed all 5 Build Release matrix entries here. This is the same problem ADR-0005 + the rust-ci.yml clippy/test/ docs/coverage jobs already work around by excluding midstream from `--all-features` invocations. The publish-crates job (line 191+) exempts midstream entirely. The build-release job is what attaches binaries to the GitHub Release; ship default-feature builds and let opt-in features re-enable once the lean_agentic retirement (per ADR-0005) lands. This unblocks the v0.2.1 binary attachments. Publish-crates is separately blocked on the `CARGO_REGISTRY_TOKEN` repo secret being set (out of my reach — repo admin only). Co-Authored-By: claude-flow <ruv@ruv.net>
ruvnet
added a commit
that referenced
this pull request
May 14, 2026
Same root cause as #73 (rust-ci.yml docs job) and #75 (release.yml build-release): `cargo doc --workspace --all-features` enables the off-by-default `lean-agentic` feature on the midstream root crate, which hits 27 unresolved-import errors in src/lean_agentic/. The v0.2.1 release run's update-docs job failed for this reason even though publish-crates succeeded — the 6 libs are live on crates.io, but the doc deploy to gh-pages didn't run. Add the same `--exclude midstream --exclude hyprstream` posture here. Future releases will get the doc deploy back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`cargo build --release --target X --all-features` on the midstream root crate enables the off-by-default `lean-agentic` feature, which exposes 27 unresolved-import errors in `src/lean_agentic/`. The v0.2.1 release run failed all 5 Build Release matrix entries here.
Same root cause that `rust-ci.yml`'s clippy/test/docs/coverage jobs already work around (and that `release.yml`'s publish-crates step exempts midstream from in #70). Build Release is what attaches binaries to the GitHub Release; ship default-feature builds and let opt-in features re-enable when the lean_agentic facade is retired per ADR-0005.
Out of band: `CARGO_REGISTRY_TOKEN` not set
The v0.2.1 publish job failed with `please provide a non-empty token`. The repo's `CARGO_REGISTRY_TOKEN` secret is empty/unset. Only a repo admin can fix this (Settings → Secrets and variables → Actions → New repository secret). Until that's set, retagging won't publish anything.
🤖 Generated with claude-flow