fix(launcher): add --allow-all-paths to copilot launch_copilot()#4447
Merged
Conversation
The Python launch_copilot() in launcher/copilot.py only added --allow-all-tools, not --allow-all-paths. When invoked non-interactively via `amplihack copilot -- -p "..."` (the pattern used by builder agents in the recipe runner), copilot denies all writes because it can neither prompt the user nor see explicit path approval. Symptom: "Permission denied and could not request permission from user" for every write attempt, leading to hollow-success runs where steps exit 0 but no files are actually modified. This brings launch_copilot() in line with rust_runner_copilot._normalize_copilot_cli_args() which already prefixes both flags for the wrapper compatibility path. Verified: end-to-end smart-orchestrator → default-workflow → builder now produces real commits and file modifications instead of hollow success. Closes #4445 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Repo Guardian - PassedAll changed files in this PR were reviewed and no ephemeral content was found.
No action required.
|
Owner
Author
Merge-Ready Evidence
Proceeding with squash merge. Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com |
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-line fix that resolves #4445.
launch_copilot()inlauncher/copilot.pyonly adds--allow-all-tools. When invoked non-interactively asamplihack copilot -- -p '...'(recipe-runner builder agents), copilot denies all writes because it can neither prompt the user nor see explicit path approval. Symptom: 'Permission denied and could not request permission from user' for every write, hollow-success runs, no actual commits._normalize_copilot_cli_args()already prefixes both flags for the wrapper compat path; this PR brings the direct launcher in line.Verified end-to-end: smart-orchestrator → default-workflow → builder now produces real commits + file modifications. See linked issue for full diagnosis.