Skip to content

chore(streamstore): remove dead type re-export block from sdk-types - #340

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-streamstore-remove-dead-type-re-export-block-331119
Open

chore(streamstore): remove dead type re-export block from sdk-types#340
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-streamstore-remove-dead-type-re-export-block-331119

Conversation

@detail-app

@detail-app detail-app Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Remove the bottom re-export block in packages/streamstore/src/internal/sdk-types.ts
(24 generated types: AccessTokenIdStr, BasinState, CreateStreamRequest, FencingToken,
Header, Metric, etc.).

This was dead code: sdk-types.ts lives under src/internal/ and is not re-exported by
the package's public barrel (index.ts). Its only importer is a single test file
(case-transform.test.ts), which does not reference any of these 24 names. All 24 types
are already publicly available via index.ts through export * as API and 12 by-name
re-exports, making this block a pure redundant duplicate with zero consumers of any
kind (production or test). The CamelCaseKeys<API.X> aliases above this block are
retained, as they are consumed by the case-transform test suite.

History


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from a team as a code owner August 20, 2026 21:06
@detail-app
detail-app Bot requested a review from sgbalogh August 20, 2026 21:06
@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown

PR author is not in the allowed authors list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant